Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run latest versions of test suites #53

Merged
merged 5 commits into from
Dec 23, 2021
Merged

Run latest versions of test suites #53

merged 5 commits into from
Dec 23, 2021

Conversation

michielbdejong
Copy link
Member

@michielbdejong
Copy link
Member Author

Tests are failing due to #54 - will add a SKIP_CONC env var to solid-crud-tests.

@michielbdejong
Copy link
Member Author

Hm, that's odd, in github actions it's getting the cookie correctly but then still can't seem to use it successfully when running the solid-crud-tests. Re-running to see if this problem is intermittent, or related to some difference between my test server and the github actions execution environment.

@Potherca
Copy link
Member

pdsinterop/php-solid-auth#18 has been merged and released as pdsinterop/solid-auth:v0.6.2

@Potherca
Copy link
Member

I've rebased this MR on the recent changes on main (mostly bug fixes) to see if/what changes in the checks.

@Potherca
Copy link
Member

Yeah, there definitely something going on with GitHub Action... Getting intermittent timeouts now as well... We might have to reconsider how the tests are currently run and/or split the actions across multiple jobs.

@Potherca
Copy link
Member

Merging this in order to keep things moving. Subsequent fixes to get the build passing can be added in later MRs. (I want to get the v0.6 release out of the door, so I can start adding the Link Metadata feature).

@Potherca Potherca merged commit 028a437 into main Dec 23, 2021
@Potherca Potherca added this to the v0.6.0 milestone Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants