Fix some outdated documentation and scripts #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potherca
approved these changes
Dec 27, 2020
There was a problem hiding this comment.
These changes look good to me.
Some are copy/paste mistakes or leftover form changes elsewhere.
Originally we were considering supporting PHP 7.1 (we even discussed 5.6) but because of downstream restrictions (and other reasons) we opted for 7.3. I'm sure that also needs changing in other repos...
|
Unless @ylebre has other insights in the coming days, I'll merge these changes this week. |
ylebre
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some of the things I changed doing some tests locally. I think all these changes make sense and there's nothing specific to my local environment.