Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test runner #27

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Update test runner #27

merged 2 commits into from
Nov 9, 2020

Conversation

michielbdejong
Copy link
Member

No description provided.

@michielbdejong
Copy link
Member Author

It seems https://github.com/pdsinterop/test-suites/blob/master/servers/php-solid-server/cookie/app/index.js#L8 works
But https://github.com/solid/solid-auth-fetcher/blob/master/src/obtainAuthHeaders.ts#L81 doesn't.

@michielbdejong michielbdejong merged commit 4803198 into master Nov 9, 2020
@michielbdejong michielbdejong deleted the update-test-runner branch November 9, 2020 15:48
@michielbdejong
Copy link
Member Author

The only difference I see is Content-Type instead of content-type as the header name, and that it uses node-fetch directly instead of through CustomAuthFetcher, but at least it works now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michielbdejong