Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: achieve login with solid.community #14

Merged
merged 7 commits into from
Oct 2, 2020
Merged

Conversation

ylebre
Copy link
Member

@ylebre ylebre commented Sep 30, 2020

No description provided.

@ylebre ylebre requested a review from Potherca September 30, 2020 17:16
added login page
small tweaks to make it in line with testsuite, passing all tests now though some are a bit faked
Copy link
Member

@Potherca Potherca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far things look good. Some minor comments, mostly for future reference. No need for changes.

src/Controller/AuthorizeController.php Outdated Show resolved Hide resolved
src/Controller/ApprovalController.php Show resolved Hide resolved
src/Controller/CorsController.php Outdated Show resolved Hide resolved
public function __invoke(ServerRequestInterface $request, array $args) : ResponseInterface
{
$clientId = $args['clientId'];
$returnUrl = $_POST['returnUrl'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference: POST parameters can be retrieved from a PSR7 Request through $request->getParsedBody()

src/Controller/ServerController.php Outdated Show resolved Hide resolved
web/index.php Outdated Show resolved Hide resolved
@Potherca Potherca added this to the v0.3.0 milestone Oct 2, 2020
added (non functional) token controller
@ylebre ylebre merged commit 1304ea5 into master Oct 2, 2020
@ylebre ylebre deleted the solid-community-login branch October 2, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants