ogg: Decode opus packet durations #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you perhaps share some example of a files/stream where this faulty behavior occurs? I found some files that pass the altered code (https://www.dwsamplefiles.com/download-opus-sample-files/) but these all give "unsupported codec" so it's not of much use. |
|
Hi @karlri, thanks for this! Apologies it took so long to get to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented this because buffering some ogg web streams seemed to hang trying to buffer up 1s of data. Turns out it was opus and the durations of all opus packets were demuxed as 0. I think I implemented this correctly but don't take my word for it. Maybe it could be of use?