Really fix visibility header on windows

pcgod · Mar 30, 2010 · 66a8546 · 66a8546
1 parent 947c5eb
commit 66a8546
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -37,6 +37,7 @@ include_directories(. ${Boost_INCLUDE_DIRS} ${OPENSSL_INCLUDE_DIR} ${CELT_INCLUD
 PROTOBUF_GENERATE_CPP(PROTO_SRCS PROTO_HDRS Mumble.proto)
 
 add_library(mumbleclient client.cc client_lib.cc CryptState.cpp ${PROTO_SRCS} ${PROTO_HDRS})
+target_link_libraries(mumbleclient ${Boost_LIBRARIES} ${OPENSSL_LIBRARIES} ${PROTOBUF_LIBRARY})
 
 option(WITH_MPG123 "Add mp3 playback support" ON)
 
@@ -46,4 +47,4 @@ if (WITH_MPG123)
 endif()
 
 add_executable (main main.cc)
-target_link_libraries (main mumbleclient ${LIBRARIES} ${CELT_LIBRARIES} ${Boost_LIBRARIES} ${OPENSSL_LIBRARIES} ${PROTOBUF_LIBRARY})
+target_link_libraries (main mumbleclient ${LIBRARIES} ${CELT_LIBRARIES} ${Boost_LIBRARIES})
diff --git a/visibility.h b/visibility.h
@@ -3,7 +3,7 @@
 		#ifdef __GNUC__
 			#define DLL_PUBLIC __attribute__((dllexport))
 		#else
-			#define DLL_PUBLIC __declspec(dllexport) // Note: actually gcc seems to also supports this syntax.
+			#define DLL_PUBLIC __declspec(dllexport)
 		#endif
 	#elif defined(BUILDING_STATIC)
 		#define DLL_PUBLIC
@@ -12,10 +12,10 @@
 		#ifdef __GNUC__
 			#define DLL_PUBLIC __attribute__((dllimport))
 		#else
-			#define DLL_PUBLIC __declspec(dllimport) // Note: actually gcc seems to also supports this syntax.
+			#define DLL_PUBLIC __declspec(dllimport)
 		#endif
-		#define DLL_LOCAL
 	#endif
+	#define DLL_LOCAL
 #else
 	#if __GNUC__ >= 4
 		#define DLL_PUBLIC __attribute__ ((visibility("default")))