Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add release notes for v2.3.1 #487

Merged
merged 8 commits into from
May 2, 2022
Merged

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented May 2, 2022

Description

Contains #482 and #483

Motivation and Context

These were fixed soon after the previous tag, should have been tagged sooner

@ZLLentz ZLLentz requested review from klauer and tangkong May 2, 2022 17:35
Copy link
Contributor

@klauer klauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was hoping for a #479 fix for our next release, but have no issues with intermediate/extra tags.

Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZLLentz
Copy link
Member Author

ZLLentz commented May 2, 2022

Pre-commit is throwing a fit in the travis- I'll handle that in this PR too

@ZLLentz ZLLentz marked this pull request as draft May 2, 2022 17:57
@ZLLentz
Copy link
Member Author

ZLLentz commented May 2, 2022

Did a big pre-commit push- in a bit I'll look through the diff

@ZLLentz ZLLentz marked this pull request as ready for review May 2, 2022 18:28
@ZLLentz
Copy link
Member Author

ZLLentz commented May 2, 2022

Pre-commit fix-up is done, tests pass- probably worth another glance

@klauer
Copy link
Contributor

klauer commented May 2, 2022

Still LGTM. Would you be up for including the versioneer upgrade as well with this PR? (-> versioneer install + adjusting typhos/__init__.py)

@ZLLentz
Copy link
Member Author

ZLLentz commented May 2, 2022

sure I'll versioneer up it

@ZLLentz
Copy link
Member Author

ZLLentz commented May 2, 2022

versioneer is updated- anything else to hammer out prior to tag?

Copy link
Contributor

@klauer klauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thing, I promise. Then let's merge/tag/move on...

typhos/__init__.py Outdated Show resolved Hide resolved
@ZLLentz
Copy link
Member Author

ZLLentz commented May 2, 2022

Travis is green again- let's get moving

@ZLLentz ZLLentz merged commit c1ad740 into pcdshub:master May 2, 2022
@ZLLentz ZLLentz deleted the v2.3.1-rel branch May 2, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants