-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: add release notes for v2.3.1 #487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I was hoping for a #479 fix for our next release, but have no issues with intermediate/extra tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pre-commit is throwing a fit in the travis- I'll handle that in this PR too |
Did a big pre-commit push- in a bit I'll look through the diff |
Pre-commit fix-up is done, tests pass- probably worth another glance |
Still LGTM. Would you be up for including the versioneer upgrade as well with this PR? (-> |
sure I'll versioneer up it |
versioneer is updated- anything else to hammer out prior to tag? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last thing, I promise. Then let's merge/tag/move on...
Co-authored-by: Ken Lauer <[email protected]>
Travis is green again- let's get moving |
Description
Contains #482 and #483
Motivation and Context
These were fixed soon after the previous tag, should have been tagged sooner