-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating upper limit of M1K2 pitch #145
Conversation
@@ -1328,7 +1328,7 @@ External Setpoint Generation: | |||
<EncPara ScaleFactorNumerator="0.00256" Offset="-25648.08" MaxCount="#xffffffff"> | |||
<FilterTime TPos="0.05"/> | |||
<SoftEndMinControl Enable="true" Range="-350"/> | |||
<SoftEndMaxControl Enable="true" Range="-25"/> | |||
<SoftEndMaxControl Enable="true"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to check on this, I think 0 might actually mean no max. To alleviate any ambiguity, I'd use -0.001. Or test this, have we tried moving to 0.02 with max set to 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NSLentz Happen to know the answer to this? I didn't see this called out in the documentation, but I believe setting the Limit Switch to 0 disables it. As seen above, the range parameter was removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nrwslac
No, setting the limit switch to zero just applies a limit at position 0. The Enable="true" would be missing if it was disabled. See below example.
Back to FALSE, but with setting value to 5:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking a look. Also, Epics limits behavior seems improved. It wont let me exceed max PLC limit pos which is nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the motion to 0.0 urad. lgtm!
Description
Updating soft limits for M1K2 pitch
From Georgi: "The upper limit currently is at -25urad, please change this to 0."
Motivation and Context
https://jira.slac.stanford.edu/browse/ECS-7089
How Has This Been Tested?
yes, looks good
Where Has This Been Documented?
https://jira.slac.stanford.edu/browse/ECS-7089
Screenshots (if appropriate):
Pre-merge checklist
Always Newest
pre-commit
(alternativelypre-commit run --all-files
)