Changes to ioctool #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZLLentz
reviewed
Jan 19, 2022
|
One more suggestion for any time you're doing a bash script: make sure you run the result through shellcheck, it can often help catch issues. |
ZryletTC
reviewed
Feb 2, 2022
…nction, and made some style changes
ZryletTC
reviewed
Mar 23, 2022
ZLLentz
approved these changes
Mar 31, 2023
| ################################################################# | ||
|
|
||
| elif [ "$CMD" == "autosave" ]; then | ||
| autosavefile=/reg/d/iocData/"${NAME}"/autosave/${NAME}.sav |
There was a problem hiding this comment.
This branch does not work for the pytmc-generated twincat IOC autosave files because the file names are different:
$ ls /cds/data/iocData/ioc-lfe-motion/autosave/
info_positions.req info_positions.sav_210325-173832 info_positions.sav_230119-152437 info_settings.sav_201118-210022 info_settings.sav_210823-132817
info_positions.sav info_positions.sav_210325-175539 info_positions.sav_230121-060135 info_settings.sav_210106-165713 info_settings.sav_210918-133200
info_positions.sav0 info_positions.sav_210326-165516 info_positions.sav_230121-123032 info_settings.sav_210115-133120 info_settings.sav_211005-100349
info_positions.sav1 info_positions.sav_210402-105142 info_positions.sav_230204-164422 info_settings.sav_210119-153527 info_settings.sav_211012-101144
info_positions.sav2 info_positions.sav_210423-095513 info_positions.sav_230220-064720 info_settings.sav_210211-110618 info_settings.sav_211021-102332
There was a problem hiding this comment.
Will make this an issue.
|
Ok I think this is good to go, I'm going click the "merge" button |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to ioctool script involved making searching through config files better, adding the option to open other useful iocInfo files, allowing camera name input to find information, addition of a "cat" option and fixed issues that dealt with multiple iocs.
Motivation and Context
Fixes #79 .
How Has This Been Tested?
Tests involved sourcing the script from my epics-dev directory using various camera, pv and ioc names.
Where Has This Been Documented?
Both scripts have updated usage functions