deviceDict changed to JSON format #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding more common setups to json. Merge will be delayed until complete. |
|
Nevermind, I don't know how they want the entries set up. I think it's better to just get this out there and new setups can be added later. |
ZLLentz
approved these changes
Mar 6, 2020
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
deviceDict is used to hold information about devices for the questionnaire. This was previously in the form of deviceDict.py. This python object was dumped in JSON format with pretty printing allowing for easier editing in the future. Edits were also made to the questionnaire_tools file to allow it to open the file from its new format.
Motivation and Context
JSON format allows for easier editing of device info for changes to questionnaire
How Has This Been Tested?
I'm not sure how questionnaire_tools is meant to be run so I've only tested it by running questionnaire_tools and seeing that it gets past my import JSON lines ok. Some help testing would be appreciated.
Where Has This Been Documented?
Nowhere :/