ENH: add messages for ssh-agent-helper exit state to make the result clear #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: I mostly want quick opinions about the word choice and the terminal output, you shouldn't spend a lot of time out of your day on this one. I think this is the normal/simplest way to check a return code in a bash script.
Description
If the
ssh-add
step inssh-agent-helper
runs, let the user know how it goes.The script remains silent if it didn't need to do anything.
Motivation and Context
This came up when @ljansen7 was deploying IOCs a week or so ago and the script output was unclear: did it work? Did it not work? Do I have to do it again?
Jira at https://jira.slac.stanford.edu/browse/ECS-6095
How Has This Been Tested?
I ran the script a few times with different conditions:
Correct password:
Wrong password a bunch, ctrl+c and skips my message
Empty password, but actually my key is encrypted still and the return code catches it
Where Has This Been Documented?
Here only, later in release notes