FIX: issues with ioc-deploy casing #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangkong
reviewed
Sep 4, 2024
|
I also ended up adding a check for readmes like this one that have the last part of the suffix in them but not the ioc-area part: https://github.com/pcdshub/ioc-common-ads-ioc/blob/master/README.md |
|
Testing for this has been lots of |
|
Thank you for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue where
ioc-deploywould happily create new folders if you make a casing typo, e.g.ioc-common-gigecamwill now deploy toioc/common/gigECam.Github URLs are case-insensitive, e.g. you can clone
ioc-coMMon-GiGeCaMand it will work just fine.So, we need to turn to other sources for the correct casing for directory deployment.
The REST API is the most consistent method, but it requires additional authentication.
This PR checks two things in order looking for a match:
Motivation and Context
https://jira.slac.stanford.edu/browse/ECS-6018
How Has This Been Tested?
Interactively only, works as I expect
Where Has This Been Documented?
Here only