-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX/ENH: fix ioc-deploy auth, provide ssh-agent-helper #190
Conversation
… and private repos
I chatted with Robert and our consensus is that this probably shouldn't set up SSH agents, but it should let you know that your agent isn't set up and suggest actions to fix this. There should also be some helpers for creating SSH keys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comments, LGTM
I fixed the stdout/stdin typo and greatly expanded the comments in ssh-agent-helper so it can be useful as a primer on how the agent setup works. |
One more to-do: I need to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for explaining the bash shenanigans to me
Sorry, I didn't have much to contribute. Read through the file changes and brushing up on bash scripting. |
Description
ioc-deploy
to git clone checks using ssh auth.ssh-agent-helper
for using the ssh-agent based on https://github.com/pcdshub/twincat-bsd-ansible/blob/master/scripts/ssh_agent_helper.shssh-agent-helper
Motivation and Context
ioc-deploy
currently only works on public repos because it receives 404s from http checks of internal and private repos for logged out users. If we instead use the user's shell's existing ssh authentication, we don't need to pass passwords around, distribute PATs, etc.How Has This Been Tested?
Interactively only
Where Has This Been Documented?
Only here, so far