ENH: add quick script for repointing afs remotes to github #189
Conversation
| print(f"origin to {new_origin}") | ||
| print(f"upstream to {new_upstream}") | ||
| confirm = input("Confirm? y/n\n") | ||
| if not confirm.lower().startswith("y"): |
There was a problem hiding this comment.
Now that click is in pcds-conda, click.confirm is a thing https://click.palletsprojects.com/en/8.1.x/prompts/#confirmation-prompts
There was a problem hiding this comment.
You're right, if I switch this to use pcds_conda click is better.
There was a problem hiding this comment.
I realize I'm just always using pcds-conda so it's not really a time loss for me.
| confirm = input("Confirm? y/n\n") | ||
| if not confirm.lower().startswith("y"): | ||
| return 1 | ||
| subprocess.run(["git", "remote", "set-url", "origin", new_origin]) |
There was a problem hiding this comment.
Are we certain everyone has a remote called origin? Maybe the more consistent thing to do is remove all the remotes then create origin and upstream
There was a problem hiding this comment.
You're right, this is a big assumption. This is definitely what you get if you just git clone from afs. Let me check what happens when you use epics-checkout.
There was a problem hiding this comment.
Here's the wild structure you get from epics-checkout, but it's still origin:
zlentz@psbuild-rhel7-03:~/.../ims/ims-git(master +)$ pwd
/cds/home/z/zlentz/temp/afs_ioc_checks/ims/ims-git
zlentz@psbuild-rhel7-03:~/.../ims/ims-git(master +)$ git remote -v
origin /afs/slac/g/cd/swe/git/repos/package/epics/ioc/common/ims.git (fetch)
origin /afs/slac/g/cd/swe/git/repos/package/epics/ioc/common/ims.git (push)
There was a problem hiding this comment.
I guess if someone was savvy enough to change their remote names from the default, they're probably savvy enough to fix this without the help of the script?
There was a problem hiding this comment.
That's my current thought too, but I'm biased by not wanting to do more work on this. I'm happy to change the behavior if it would be helpful.
There was a problem hiding this comment.
I think this is good enough for the purpose. probably more important to get this out there for the migration
|
I'll leave these up for a bit longer to allow for other reviews (from the slack post) |
|
If someone comes here later from slack: please still do a post-merge review if you'd like, we can change these scripts as needed. |
Description
Add
afs-remote-fix(afs_remote_fix.py), a tiny script for changing a user's afs remote to point toward their fork and to pcdshub.Motivation and Context
We're migrating the afs repos so this will be useful.
How Has This Been Tested?
Interactively only
Where Has This Been Documented?
Here only in the readme and in the file