Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: remove glx env var, no longer needed and causing issues #187

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Jul 2, 2024

Description

Remove opengl-related environment variable from the conda startup scripts

Motivation and Context

At LCLS, this was a temporary workaround that is causing a new issue.

In general, forcing the renderer settings in the conda environment sourceable led to a very confusing bug. This should have been handled (and seemingly has been handled) by adjusting the server settings.

I'm not sure why this variable is causing crashes now, but I am sure that I don't want to be in charge of messing with these sorts of settings in the future.

How Has This Been Tested?

Interactively only, as me

Where Has This Been Documented?

Only here and on Jira in https://jira.slac.stanford.edu/browse/ECS-5700

@ZLLentz ZLLentz marked this pull request as ready for review July 8, 2024 22:16
@ZLLentz ZLLentz requested a review from tangkong July 8, 2024 22:16
Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 This should really be outside of our wheelhouse, and this gets us closer to that

@ZLLentz ZLLentz merged commit 1b21455 into pcdshub:master Jul 8, 2024
2 checks passed
@ZLLentz ZLLentz deleted the maint_remove_glx_var branch July 8, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants