-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add getPVAliases and grep_more_ioc scripts #180
Merged
Merged
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d400a57
ENH: Added script for reconstructing PV aliases
aberges-SLAC 05ab06e
MNT: Fixed relative path reference on getPVAliases wrapper
aberges-SLAC c9df901
STY: conform to flake8 DOC: type hint returns ENH: consolidate bash s…
aberges-SLAC e2e7300
MNT: read hutch codes from '...pyps/config'
aberges-SLAC 35474cb
ENH: Added grep_more_ioc.py and associated shell wrapper, simiplified…
aberges-SLAC 0c19339
BUG: Fixed bugs on parent release prints and fixed rel. path in shell…
aberges-SLAC 9d028c3
MNT: flake8, general style, shellcheck
aberges-SLAC 7eb1c33
MNT: Fixed help doctext for grep_more_ioc argparser
aberges-SLAC 655c7b9
MNT: Proper quoting for in grep_more_ioc.sh
aberges-SLAC 607a972
MNT: sort imports for style enforcement
aberges-SLAC f31039f
MNT: isort, once more with feeling
aberges-SLAC 04d62b3
MNT: isort is not my friend
aberges-SLAC 07eb6f7
BUG: Fixed bad catches on find_parent_ioc in grep_more_ioc.py
aberges-SLAC fa19600
MAINT: Various bugfixing, style fixing, incorporating review changes
aberges-SLAC d183294
STY: flake8 and isort compliance
aberges-SLAC 43d391f
MAINT: One last bug fix and style fix
aberges-SLAC ad07b6f
MAINT: more style fixing
aberges-SLAC 122d4ff
BUG/ENH: Fixed missing IOCs due to inline breaks. Added search_procmg…
aberges-SLAC 06a21bb
DOC: Improved help documentation for grep_more_ioc and getPVAliases
aberges-SLAC b2037ed
DOC: Updated README.md to include new scripts
aberges-SLAC e3bfae4
DOC: Update README.md
aberges-SLAC 09fd47e
MAINT: Rename getPVAliases.sh to getPVAliases
aberges-SLAC be4e07e
MAINT: Rename grep_more_ioc.sh to grep_more_ioc
aberges-SLAC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# -*- coding: utf-8 -*- | ||
""" | ||
Constants used in grep_more_ioc and getPVAliases | ||
""" | ||
############################################################################### | ||
# %% Imports | ||
############################################################################### | ||
|
||
import glob as gb | ||
|
||
############################################################################### | ||
# %% Constants | ||
############################################################################### | ||
|
||
# Check the directories for the iocmanager config file | ||
VALID_HUTCH = sorted([d for d in gb.glob('/cds/group/pcds/pyps/config' | ||
+ '/*/') | ||
if gb.glob(d + 'iocmanager.cfg')]) | ||
# Trim to 3 letter hutch code, include 'all' = '*' | ||
VALID_HUTCH = ['all'] + [s.rsplit(r'/', maxsplit=2)[-2] for s in VALID_HUTCH] | ||
|
||
# Keys from iocmanager. Found in /cds/group/pcds/config/*/iocmanager/utils.py | ||
# Update this as needed | ||
DEF_IMGR_KEYS = ['procmgr_config', 'hosts', 'dir', 'id', 'cmd', | ||
'flags', 'port', 'host', 'disable', 'history', | ||
'delay', 'alias', 'hard'] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script is actually
grep_more_ioc.sh
, I think we should document as such here or rename the scripts to not have .sh suffixes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd vote to not have .sh as most scripts in engineering tools do not have extensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To hop on to the readme suggestions, could you add an example call for those of us who don't know what pattern/hutch to search for? I think examples are helpful for people not so familiar with EPICS and our systems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if this script renaming/examples stuff get in then this PR has my approval (I don't want to hold it up any longer, but I'd like the names to be finalized + I'd like people to be ready to use it when it gets merged)