motor-expert-screen checks for smaract-specific pvs so it works… #174
Conversation
… with aliases without MCS2 in their prefix
There was a problem hiding this comment.
In general this approach is good if it is needed
This file is starting to get awkward though- we're getting upwards of 4 PVs in series, subjecting ourselves to potentially multiple CA timeouts. I have to wonder if a refactor is on the horizon.
| edm -x -eolc -m "MOTOR=$PREFIX" mcs2_openloop.edl > /dev/null 2>&1 & | ||
| fi | ||
| else | ||
| cd /reg/neh/home/klg/epics/ioc/common/aerotech/current/motorScreens |
There was a problem hiding this comment.
Woah, just noticed this. Why are we running screens out of Karl's (or Mike's) home directory? And why is that the fallback?
There was a problem hiding this comment.
This showed up in the diff because I nested an existing conditional block. I could add /reg/g/pcds/epics/ioc/common/aerotech/R1.2.0/motorScreens to EDMDATAFILES and use ens_main.edl without changing directories. Is that reasonable?
There was a problem hiding this comment.
Moving to a released version is best, but that's a issue un-related to your PR. I'm still a little puzzled about the way this script decides to open the aerotech screen. I'll think about this more, and perhaps open a separate issue on this repo.
There was a problem hiding this comment.
I agree, this is a problem but it's not a new problem
There was a problem hiding this comment.
I made a new issue for this here: #175
|
I'm going to run this myself a few times and then approve |
KaushikMalapati
changed the title
… with aliases without MCS2 in their prefix
Description
Logic to select which edm screen to use now checks if LSCO_RBV pv is present, which is a smaract specific pv.
Motivation and Context
Some smaract axes have aliases without MCS2 in their prefix, so before they would use the default aerotech edm screen when launched from motor-expert-screen instead of a smaract screen.
https://jira.slac.stanford.edu/browse/ECS-4401
How Has This Been Tested?
Launching motor-expert-screen with a smaract alias pv without mcs2 in its prefix and a smaract pv with mcs2 in its prefix and ensuring it uses a smaract screen instead of an aerotech screen.
Where Has This Been Documented?
A comment in the code has been updated