Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully test the event masks and fix temp file name #144

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

mcb64
Copy link
Contributor

@mcb64 mcb64 commented Jan 19, 2023

Added the PID to the temporary file name to hopefully avoid collisions should two people be running the script at once.

The old version of the script only tested a few possible event mask values, the largest being 16, which didn't seem to be correct anyway. The detail part of the script has been rewritten to really test the values in the event mask, and also complain if the mask contains any values not supported by an event process.

@mcb64 mcb64 requested a review from silkenelson January 19, 2023 18:52
Copy link
Collaborator

@silkenelson silkenelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silkenelson silkenelson merged commit 570e077 into pcdshub:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants