Added the new subnets to get_info
#13
Conversation
|
Seems fine to me, if you're sure all the subnet numbers are correct (not sure where the official list for those is). Thoughts on adding a line for |
|
the list for XPP seems a bit strange (it seems to be missing its FEZ network and has the ICS as an XPP specific one), though that weirdness predates these changes. The FEZ for XPP is 22. Also the ICS subnet is 46, but that shouldn't be a hutch specific one, so I don't know why it is listed under XPP. Also you could add the det FEZ subnet which is 59. |
Usage: host_checkup <hostname> Host netconfig entry: ------------------------------------------------- Checking IPMI power status: ------------------------------------------------- Checking host/ipmi/fez network interfaces are online: ------------------------------------------------- does not ping. -ipmi does not ping. -fez does not ping. is offline. Skipping internal checks. ------------------------------------------------- PCDS Drivers: /reg/g/pcds/dist/pds/boot/ ------------------------------------------------- for server diagnostics
…now arrays for networks that range over several octets.
|
We should finish up and merge this PR. Since it's connected to @rajanplumley 's master branch, its scope is increasing. |
|
We can merge once Dan and Silke's comments are addressed. In the future I will try to dismiss PRs from master branches early to prevent scope creep. |
|
Merging finally |
|
typo in rc/pcds_shortcuts.sh? |
|
Fixed in #19 |
|
In the future, we need to avoid making PRs from user master branches. PRs should be from a single non-master branch with a very well-defined set of changes. In this case, we didn't review the changes unrelated to adding new subnets and there was a typo. |
Replaced old CDS subnets in
get_infowith new ones so all the scripts that get hutch won't break.Tested on XCS machines because they're the only ones that work.
Please review in case I missed any of the new subnets.