Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: now geometry deploy by default for relevant detectors #123

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

vespos
Copy link
Contributor

@vespos vespos commented Jul 16, 2022

Description

Fix geometry deployment in makepeds

Motivation and Context

Now the geometry is automatically deployed for the relevant detectors. The geometry deployment has been moved at the end of the pedestal processing, so that relevant folders are created.
Add ffb queue 4 to ffb queue list

How Has This Been Tested?

./makepeds -u espov -r 2 -q ffbh4q
os xppopr for xpplz0020

Where Has This Been Documented?

N/A

@vespos vespos requested a review from silkenelson July 16, 2022 00:27
Copy link
Collaborator

@silkenelson silkenelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@ZryletTC ZryletTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@vespos vespos changed the title now geometry deploy by default for relevant detectors ENH: now geometry deploy by default for relevant detectors Jul 18, 2022
@vespos
Copy link
Contributor Author

vespos commented Jul 18, 2022

Thanks, merging now!

@vespos vespos merged commit 2929c6d into pcdshub:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants