Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in ipmConfigEpics changed instances of sc1ipm to usrdio #120

Merged
merged 1 commit into from
May 26, 2022

Conversation

c-tsoi
Copy link
Contributor

@c-tsoi c-tsoi commented May 25, 2022

Description

In the script, ipmConfigEpics I changed the sc1ipm to usrdio in the three instances it appears in. This was per Tyler's request to make the names more intuitive.

Motivation and Context

https://jira.slac.stanford.edu/browse/LCLSECSD-1131

How Has This Been Tested?

I ran the command using the change in variable name and got the same results.

Where Has This Been Documented?

@ZLLentz ZLLentz requested a review from ZryletTC May 26, 2022 17:24
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me, based on the description here

@ZLLentz
Copy link
Member

ZLLentz commented May 26, 2022

I just remembered that Tyler is on vacation- I'm adding Silke as a reviewer for awareness and I'll merge if she doesn't object

@ZLLentz ZLLentz requested a review from silkenelson May 26, 2022 17:42
Copy link
Collaborator

@silkenelson silkenelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember the context and this looks fine to me

@ZLLentz ZLLentz merged commit f93fc6d into pcdshub:master May 26, 2022
@ZLLentz
Copy link
Member

ZLLentz commented May 26, 2022

👍 this is now merged

Comment on lines 135 to 137
IOC="IOC:CXI:SC1:BMMON"
BASE='CXI:SC1:BMMON'
EVR='CXI:SC1:BMMON:EVR'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c-tsoi Can you please do a follow-up PR to edit these PVs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants