-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh/plotped lcls2 #113
Enh/plotped lcls2 #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me. I'd like Vincent's eyes on it as well since the epix10k section is pretty dense. Did you also test with the makepeds run non-locally?
Co-authored-by: Tyler Pennebaker <[email protected]>
In my experience, testing the full makepeds is messy as I usually have to hack makepeds to call the changed makepeds_psana instead of the default and then remember to fix that before committing. As I have not actually changed makepeds I've deemed this an unnecessary step in this instance. |
I'm surprised you'd need to hack makepeds. It looks like it runs the makepeds_psana script in the current directory: |
It's possible that I worked around my earlier problems with makepeds - my memory is somewhat hazy. |
changes for UED to enable restartdaq, stopdaq & makepeds
Description
Check for LCLS2 hutches in a better way & add UED as an LCLS2 hutch
expand makepeds_psana to also work for LSL2 (epixquad only tested detector for now)
Motivation and Context
UED should have the same tools used elsewhere
How Has This Been Tested?
ran makepeds_psana locally
Where Has This Been Documented?
nowhere as usual.