Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Changed the takepeds to automatically pick a station #112

Merged
merged 7 commits into from
Mar 5, 2022

Conversation

aoluwade
Copy link
Contributor

@aoluwade aoluwade commented Mar 3, 2022

Description

Used get_info --getstation to get the current station.
Added a usage function.

Motivation and Context

It automatically gets the station for the user as opposed to the default station 0 before.

How Has This Been Tested?

Tested on cxi-daq and cxi-monitor and it works fine.

Where Has This Been Documented?

Added a usage fucntion in the script

@aoluwade aoluwade requested review from ZryletTC and silkenelson March 3, 2022 02:04
Copy link
Collaborator

@silkenelson silkenelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the commit message had be worried the '-r' was gone, the code looks good to me. I assume this was tested in the two CXI endstations?

Copy link
Contributor

@ZryletTC ZryletTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on tests...
Could you also please add a usage? (look at other scripts for examples)

@aoluwade
Copy link
Contributor Author

aoluwade commented Mar 4, 2022

A usage function has been added.

@aoluwade
Copy link
Contributor Author

aoluwade commented Mar 5, 2022

Waiting on tests... Could you also please add a usage? (look at other scripts for examples)

Tested on cxi-daq and cxi-monitor and it works.

scripts/takepeds Outdated Show resolved Hide resolved
@ZryletTC ZryletTC merged commit 0eb2d68 into pcdshub:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants