Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add ued to get_info #108

Merged
merged 1 commit into from
Mar 1, 2022
Merged

ENH: add ued to get_info #108

merged 1 commit into from
Mar 1, 2022

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Mar 1, 2022

Description

Add an entry for UED to get_info

Here is the interface configuration on ued-daq for reference:

$ ifconfig
enp65s0f0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 9000
        inet 172.21.36.27  netmask 255.255.255.0  broadcast 172.21.36.255

Motivation and Context

get_hutch_name fails in ued

How Has This Been Tested?

zlentz@ued-daq:~/.../engineering_tools/scripts(add-ued +)$ ./get_info --gethutch
ued

Where Has This Been Documented?

N/A

@ZLLentz ZLLentz requested review from ZryletTC and silkenelson March 1, 2022 22:48
silkenelson
silkenelson approved these changes Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@silkenelson silkenelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had the same changes waiting in my makepeds code, but the earlier, the better....

ZryletTC
ZryletTC approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@ZryletTC ZryletTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ZryletTC ZryletTC merged commit 1b555b7 into pcdshub:master Mar 1, 2022
@ZLLentz ZLLentz deleted the add-ued branch March 2, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silkenelson silkenelson silkenelson approved these changes

@ZryletTC ZryletTC ZryletTC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZLLentz @ZryletTC @silkenelson