Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Misc updates #56

Merged
merged 4 commits into from
Sep 16, 2024
Merged

MNT: Misc updates #56

merged 4 commits into from
Sep 16, 2024

Conversation

tangkong
Copy link
Contributor

@tangkong tangkong commented Aug 30, 2024

Description

  • updates conda recipe to explicitly include setuptools as a build backend, anticipating py3.13's dropping of setuptools from pip's dependency list
  • replace isort/flake8 with ruff, in an aggressive setting

Motivation and Context

I really don't know what to title this

Examining the ignore-rules as I moved them into pyproject.toml

  • W503, W504: Don’t exist in ruff, conflicts with black (aka ruff format) -- will be dropped
  • E203: disallows whitespace before punctuation (,, ;, :) -- I think we can probably re-enable this rule
  • E501: Line too long — I’m in favor of enabling this rule, as we’ve already extended our max line length
  • E226: whitespace around arithmetic ops — I’m in favor of enabling this rule too, making 40+2 bad style again

I think with ruff format enabled, it's probably reasonable to remove these exceptions altogether

How Has This Been Tested?

N/A

Where Has This Been Documented?

This PR

@tangkong
Copy link
Contributor Author

tangkong commented Sep 5, 2024

whoops forgot to request reviews here

@tangkong
Copy link
Contributor Author

Again I forgot about this. Merging 👍

@tangkong tangkong merged commit d01e218 into pcdshub:master Sep 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants