Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: add egg_generator for re-creating serialized json artifacts #65

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

tangkong
Copy link
Contributor

@tangkong tangkong commented Nov 1, 2024

Description

  • Adds a 🐔 so we can make 🥚 whenever our model schema changes

Motivation and Context

If we're re-doing how tagged unions etcs are defined, we'll need to re-generate the json serialized configs

How Has This Been Tested?

I ran python egg_generator.py once, and confirmed they re-made the configs

Where Has This Been Documented?

This PR

Pre-merge checklist

  • Code works interactively
  • Code follows the style guide
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

ZLLentz
ZLLentz previously approved these changes Nov 1, 2024
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on board. Looks normal and useful.

If we find issues with this we can tweak it in the subsequent PRs that find the issue.

@ZLLentz
Copy link
Member

ZLLentz commented Nov 1, 2024

@joshc-slac do you have a script you used to generate im2l0_test.json?
If you do, I'd like to add it to this (since my schema updates in #59 also break the im2l0 test case)

ZLLentz added a commit to ZLLentz/BEAMS that referenced this pull request Nov 1, 2024
@tangkong
Copy link
Contributor Author

tangkong commented Nov 4, 2024

I added the im2l0 egg generator manually. Josh knows this, but there's a few changes that need to be made before it's a sensible, operational test against the real IOC (don't caput to .RBV, handle enums, add tolerances for equality checks)

@tangkong tangkong requested a review from ZLLentz November 4, 2024 17:48
@tangkong tangkong merged commit 9730b61 into pcdshub:master Nov 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants