-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: addressing issue #56, allowing for us to determine how often we caput #64
base: master
Are you sure you want to change the base?
Conversation
d49a5ee
to
8df553d
Compare
8163b9c
to
bd66cfe
Compare
|
||
termination_check: ConditionItem = field(default_factory=ConditionItem) | ||
|
||
def __post_init__(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this timer stuff probably makes the most sense living in the ActionNode, not the tree-item class. The purpose of the *Item
here is to assist with serialization, and the *Node
does the actual work.
We already did a bunch of work moving references away from the TreeItem into the ActionNode, it feels like a step backward to do so again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a very good point
8df553d
to
a2c1edb
Compare
… ActioNodeWorker, added functional timeout ability, tested
bd66cfe
to
9e7de8b
Compare
3a9badf
to
277f99c
Compare
Description
This is likely not the best way to do this but I want to motivate a few things:
tree_config.py
into logical unitsMotivation and Context
We don't necessarily want to spam EPICS with caput requests. This is a mechanism to do that
How Has This Been Tested?
Extended test cases to exercise this feature
Where Has This Been Documented?
Probably needs a little something
##Alternatives:
Instantiating a semaphore in ActionNode that is passed to ActionWorker to be wrapped and then using the semaphore to pass ticks which gate execution of the work function might be cleaner.
Pre-merge checklist
docs/pre-release-notes.sh
and created a pre-release documentation page