Added when keyword

[VonTum]

• added when literal to grammar
• updated auto generated tree-sitter configs
• added "is_when" bool to if-struct

[VonTum]

First half is here: ceeccc6 , if you want to take a look at it @VonTum . The insane amount of line changes are because I had to regenerate the tree-sitter stuff. Is this normal or did I break something?

I will start a merge request once I get the warnings to work.

Curious, from my first look through parser.c, the massive line count difference is explained by differing tree-sitter versions. Perhaps you're using a slightly newer version of tree-sitter do do your generation? Could you check tree-sitter --version for me?

In general though, you don't need to worry about line changes in parser.c or any of the other generated files. It's usually good practise to have a look at the changes, because tree-sitter generates reasonably readable C code, and I especially just look at the upper header, at STATE_COUNT, LARGE_STATE_COUNT, and others to see if a change I've made drastically messes up the generated parser.

[VonTum]

Looks like a good start! The parser update looks good, all that is left is to add the necessary warning/error, and make the is_generative depend on the keyword, instead of the context.

[VonTum]

There's TODO's like this one scattered around the codebase. I believe you can get rid of is_generative when you add the warning inline here. (Or even have is_generative get the value of literal_is_when, rather than from its context)

[TomSkarabis]

i have now made the following changes which should resolve this:

sus-compiler/src/flattening/flatten.rs

Lines 1120 to 1136 in 87472ca

	match(keyword_is_if, condition_is_generative){
	(true, false) => {
	self.errors.warn(position_statement_keyword, "Used 'if' in a non generative context, use 'when' instead");
	},
	(false, true) => {
	self.errors.error(position_statement_keyword, "Used 'when' in a generative context, use 'if' instead");
	},
	(_, _) => ()
	}
	let if_id = self.instructions.alloc(Instruction::IfStatement(IfStatement {
	condition,
	is_generative: keyword_is_if,
	then_start: FlatID::PLACEHOLDER,
	then_end_else_start: FlatID::PLACEHOLDER,
	else_end: FlatID::PLACEHOLDER,
	}));

[TomSkarabis]

@VonTum I think that this is now ready to merge. Do you want me to rebase or merge from master to update the branch?

[VonTum]

So it appears that because I technically created the PR, I'm not allowed to review it. You live you learn I guess :P

The changes look good, all that is left is properly merging master into it, and then merging the PR. Good work!

[VonTum]

Alright, everything looks good. Great work!