Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAT-24471: allow actions_enabled as an argument #56

Merged
merged 7 commits into from
Oct 29, 2024
Merged

CAT-24471: allow actions_enabled as an argument #56

merged 7 commits into from
Oct 29, 2024

Conversation

socketbox
Copy link
Collaborator

  1. Remove redundant calls to optional() in variable declaration
  2. Pass in object element to resource

@socketbox socketbox requested a review from ehirsch-3pg October 8, 2024 16:07
ehirsch-3pg
ehirsch-3pg requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@ehirsch-3pg ehirsch-3pg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on the alarm_config variable definition.

optional-alarm.tf Show resolved Hide resolved
@socketbox socketbox force-pushed the CAT-24471-actions_enabled branch from 35ed569 to 548eab2 Compare October 15, 2024 14:17
@socketbox socketbox merged commit 765be79 into main Oct 29, 2024
@socketbox socketbox deleted the CAT-24471-actions_enabled branch October 29, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehirsch-3pg ehirsch-3pg ehirsch-3pg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@socketbox @ehirsch-3pg