#49 add: catch general exceptions

Signed-off-by: Patrizio Bekerle <[email protected]>
pbek · Sep 17, 2024 · 6927924 · 6927924
1 parent 41e44d5
commit 6927924
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/Controller/NoteApiController.php b/lib/Controller/NoteApiController.php
@@ -20,6 +20,7 @@
 use OCA\Files_Versions\Storage;
 use OCP\AppFramework\ApiController;
 use OCP\IRequest;
+use OCP\Util;
 
 class NoteApiController extends ApiController
 {
@@ -57,11 +58,11 @@ public function getAllVersions()
     {
         $source = $this->request->getParam('file_name', '');
         $errorMessages = [];
+        $versionsResults = [];
 
         try {
             [$uid, $filename] = Storage::getUidAndFilename($source);
             $versions = Storage::getVersions($uid, $filename, $source);
-            $versionsResults = [];
 
             if (is_array($versions) && (count($versions) > 0)) {
                 require_once __DIR__.'/../../3rdparty/finediff/finediff.php';
@@ -93,9 +94,9 @@ public function getAllVersions()
             }
         } catch (\OCP\Files\NotFoundException $exception) {
             // Requested file was not found, silently fail (for now)
-            $versionsResults = [];
-
             $errorMessages[] = 'Requested file was not found!';
+        } catch (Exception $exception) {
+            $errorMessages[] = 'An error happened: ' . $exception->getMessage();
         }
 
         return [