-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add foundation for marshalyamlinline and render inline #114
feat: add foundation for marshalyamlinline and render inline #114
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 99.77% 99.76% -0.02%
==========================================
Files 146 146
Lines 9970 10091 +121
==========================================
+ Hits 9948 10067 +119
- Misses 22 24 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! The only think remaining here is to recover test coverage. As you can see from the existing coverage, it's as high as it can be (99.8%), which gives us a coverage of 100%.
This PR drops coverage by 1% and we will lose our 100% status.
I don't want to let that happen, it took a lot of work to attain it, and it keeps quality as high as possible.
@daveshanley oh wild, did the code coverage just run 4 hours ago? I didn't even see this when i opened the PR after the build finished 🤦 . I will absolutely add that :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Great! Thank you so much for your contribution! |
No description provided.