Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add foundation for marshalyamlinline and render inline #114

Merged
merged 3 commits into from
May 25, 2023

Conversation

marclave
Copy link
Contributor

@marclave marclave commented May 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (08c9ca8) 99.77% compared to head (24582d0) 99.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   99.77%   99.76%   -0.02%     
==========================================
  Files         146      146              
  Lines        9970    10091     +121     
==========================================
+ Hits         9948    10067     +119     
- Misses         22       24       +2     
Flag Coverage Δ
unittests 99.76% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamodel/low/v3/paths.go 98.71% <ø> (ø)
datamodel/high/base/tag.go 100.00% <100.00%> (ø)
datamodel/high/v3/document.go 100.00% <100.00%> (ø)
datamodel/high/v3/media_type.go 100.00% <100.00%> (ø)
datamodel/high/v3/operation.go 100.00% <100.00%> (ø)
datamodel/high/v3/parameter.go 100.00% <100.00%> (ø)
datamodel/high/v3/path_item.go 100.00% <100.00%> (ø)
datamodel/high/v3/paths.go 100.00% <100.00%> (ø)
datamodel/high/v3/request_body.go 100.00% <100.00%> (ø)
datamodel/high/v3/response.go 100.00% <100.00%> (ø)
... and 1 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The only think remaining here is to recover test coverage. As you can see from the existing coverage, it's as high as it can be (99.8%), which gives us a coverage of 100%.

This PR drops coverage by 1% and we will lose our 100% status.

I don't want to let that happen, it took a lot of work to attain it, and it keeps quality as high as possible.

@marclave
Copy link
Contributor Author

marclave commented May 16, 2023

@daveshanley oh wild, did the code coverage just run 4 hours ago? I didn't even see this when i opened the PR after the build finished 🤦 .

I will absolutely add that :)

@marclave marclave requested a review from daveshanley May 22, 2023 17:42
Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@daveshanley
Copy link
Member

Great! Thank you so much for your contribution!

@daveshanley daveshanley merged commit 93f591d into pb33f:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants