-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't lose the focus when refreshing a thread #1499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is obviously a hack but it patches over some intrinsic urwid/notmuch problems that lots of users seem to care about, so I'm willing ot add it.
Please fix the avoidable codeclimate issues where possible.
I've triggered travis to re-run the docs generation. Something fails there. This needs to be fixed before merging.
084d707
to
08a9bf5
Compare
I fixed the |
Thanks. Did you rebase to master already? I believe these travis-docs issues are fixed on master.. |
08a9bf5
to
0b4284b
Compare
I rebased on |
Ah right: you've changed some config options but did not re-generate the docs locally (which will generate some tables that need to be checked in).
I saw that you did this for your original R but perhaps not after the rebase.. |
This commit allows keeping the currently focused message selected across thread refreshes. Since this operation can take a long time in large threads, a `search_threads_rebuild_limit` option is introduced. When defined, it sets the maximum amount of messages that will be iterated upon when trying to find the previously focused message.
0b4284b
to
a51c3ea
Compare
This looks good to me now, but with out having tested this. |
I've tested this myself just now and it looks quite good. It should be nice do include a similar patch for thread mode as well, where I personally use the refresh command much more often to check on new mails in a thread. It seems to have exposed a (unrelated?) bug in the email module for me:
|
It seems my last issue is unrelated. I have created a new issue for his (#1506). |
This commit allows keeping the currently focused message selected
across thread refreshes.
Since this operation can take a long time in large threads, a
search_threads_rebuild_limit
option is introduced. When defined,it sets the maximum amount of messages that will be iterated upon
when trying to find the previously focused message.