Delete product image instead of set remove=1

payutc · Sep 13, 2013 · 47b376f · 47b376f
1 parent 0aa1bbf
commit 47b376f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 14 deletions.
diff --git a/src/Payutc/Bom/Product.php b/src/Payutc/Bom/Product.php
@@ -265,7 +265,8 @@ public static function delete($id, $fun_id) {
         }
 
         // start transaction
-        Dbal::beginTransaction();
+        $conn = Dbal::conn();
+        $conn->beginTransaction();
 
         try {
             // 2. remove article
@@ -279,19 +280,14 @@ public static function delete($id, $fun_id) {
                 ->setParameter('id', $id);
             $qb->execute();
 
-            // 4. remove image
-            $qb = Dbal::createQueryBuilder();
-            $qb->update('ts_image_img', 'img')
-                ->where('img_id = :id')
-                ->set('img_removed', 1)
-                ->setParameter('id', $don['img_id']);
-            $qb->execute();
+            // 4. delete image
+            $conn->delete('ts_image_img', array('img_id' => $don['img_id']));
 
             // commit
-            Dbal::commit();
+            $conn->commit();
         }
         catch (Exception $e) {
-            Dbal::rollback();
+            $conn->rollback();
             return array("error"=>400, "error_msg"=>"Erreur lors de la suppression de l'objet $id.");
         }
 

diff --git a/tests/ProductRwdbTest.php b/tests/ProductRwdbTest.php
@@ -108,13 +108,12 @@ public function testDelete() {
         }
         // check the image has been removed too
         $qb = Dbal::createQueryBuilder();
-        $q = $qb->select('img_removed')
+        $q = $qb->select('count(*) as count')
                 ->from('ts_image_img', 'img')
                 ->where('img_id = :id')
                 ->setParameter('id', $img_id);
-        $img = $q->execute()->fetch();
-        $this->assertNotNull($img);
-        $this->assertEquals(1, $img['img_removed']);
+        $res = $q->execute()->fetch();
+        $this->assertEquals(0, $res['count']);
     }
 }