add validations for isEligible merchant payload #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsbrunson
approved these changes
Jan 2, 2025
siddy2181
added a commit
that referenced
this pull request
Jan 3, 2025
… nonce (#2452) * chore: prettier * allow three-domain-secure component * refactor threedomainsecure component to class * correct typo * refactor test for class component * chore: fix lint * chore: fix flow issues * pin flow-remove-types and hermes-parser version due to flow errors * return methods only instead of entire class * modify interface to reflect future state * resolve WIP stash merge * implement isEligible request to API * change sdktoken to idtoken * modify protectedExport to Local or Stage check * change protectedexport to local/stage export * pass transaction context as received * fix flow type errors * linting / flow fixes and skipping test for now * add isEligible test skeleton * check for payer-action rel in links * throw error on API error isntead of false * wip: add test for isEligible * remove comments * additional test for isEligble * remove console logs * add threeDS overlay component * add styling for 3DS iframe overlay * update overlay, save 3ds comp on eligibility to class variable * fix stage url,nit * fix lint * fix lint/typecheck * fix tests * fix tests * fix something please * test with dub in stage * remove port * test api subdomain * add sdkMeta, logs, fix css * wip * pass braintree-version header to gql * fix lint * fix typecheck * skip test * add domain * testing only fix * add allowParentDomain * add globals and enable automatic config * render zoid in parent, pass payerActionUrl prop * fix lint * fix show() response back to merchant * call eligibility api with an lsat * fix response back to the merchant * fix response back to the merchant * console logs cleanup * add tests for interface and api * add test - utils.jsx * add devOnlyExport, cleanup * reverted dist content * fix test for protected export * fix test for protected export * address review comments * remove automatic:true flag tests, make show async * wrap show around native promise to make await-able fix types fix types typecheck * add lsat support for Partner integration * fix lint tests * update tests * add validations for isEligible merchant payload (#2459) * fix validation logic * fix typecheck --------- Co-authored-by: Mervin Choun <[email protected]> Co-authored-by: Brian Tedder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds validations for
amount,currency, andnonceto 3DS component'sisEligiblemethod.Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!