fix(hosted-buttons): fix an issue where shipping callbacks would not throw #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjstires
commented
Aug 21, 2024
| @@ -636,10 +636,20 @@ describe("buildHostedButtonOnShippingAddressChange", () => { | |||
| status: 500, | |||
| }) | |||
| ); | |||
| // $FlowIssue | |||
| await onShippingAddressChange(data, actions); | |||
There was a problem hiding this comment.
The test is titled, "throws error when shipping-options api doesn't return 200" yet in the original test the callback does not throw. The test only verifies that the actions.reject method was called.
Comment on lines
+646
to
+648
| await expect(onShippingAddressChange(data, localActions)).rejects.toThrow( | ||
| errors.ADDRESS_ERROR | ||
| ); |
There was a problem hiding this comment.
We now verify that the callback actually throws its error, which allows for the error to propagate up to the calling client component as expected.
wsbrunson
approved these changes
Aug 21, 2024
imbrian
approved these changes
Aug 21, 2024
rjstires
force-pushed
the
defect/return-rejected-error
branch
from
b448445 to
b76c80f
Compare
ravishekhar
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of calling actions.reject was not being returned, causing the callback to not reject when the consumer passed an action.reject that rejects.
Description
The existing onShippingChange and onShippingOptionsChange callbacks used by hosted buttons do not return the result of calling the client application supplied action.reject method. This allows execution to continue and the callback resolves as if it were successful.
This causes the need for unsightly and hard to test error handling scenarios in the client application.
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
(ticket incoming) Supporting NCPS shipping callbacks.
Reproduction Steps (if applicable)
Passing
{ reject: message => Promise.reject(message) }when calling either callback from the client application and the callback will not reject. See original test and changes for confirmation.Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!