feat: add country prop/param to checkout #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbrian
changed the title
wsbrunson
approved these changes
Aug 6, 2024
ravishekhar
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checkout is expecting
country.xquery param, in additional tolocaleto support additional languages. Addscountryprop withcountry.xquery param, derived from thelocaleprop. This matches the implementation inpayment-fieldscomponent.Also pass this to
card-formcomponent.Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
LI-48750, LI-43951
Reproduction Steps (if applicable)
Add
locale=de_DEquery param to SDK script. Click PayPal button.Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!