Button Redesign: Colors 👾 #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsbrunson
approved these changes
Jan 22, 2024
|
@spencersablan, looks like screenshots need to be updated, but other than that |
.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2317 +/- ##
=======================================
Coverage 51.30% 51.30%
=======================================
Files 104 104
Lines 2037 2037
Branches 604 604
=======================================
Hits 1045 1045
Misses 889 889
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nikrom17
approved these changes
Jan 25, 2024
spencersablan
added a commit
that referenced
this pull request
Feb 1, 2024
This reverts commit d597263.
ravishekhar
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
JIRA: https://paypal.atlassian.net/browse/DTPPCPSDK-1678
As part of the Button Redesign project, this PR updates the colors! Here's the rundown:
#FFC439to#FFD140#555555to#001435#001435Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!