Add ShopperInsights component #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsbrunson
reviewed
Dec 5, 2023
elizabethmv
force-pushed
the
shopper-insights
branch
from
114d63b to
26eefe3
Compare
wsbrunson
reviewed
Dec 11, 2023
elizabethmv
force-pushed
the
shopper-insights
branch
from
8f043a7 to
b51301b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2286 +/- ##
=======================================
Coverage 51.18% 51.18%
=======================================
Files 104 104
Lines 2032 2032
Branches 601 601
=======================================
Hits 1040 1040
Misses 889 889
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
elizabethmv
force-pushed
the
shopper-insights
branch
from
b51301b to
b61e125
Compare
wsbrunson
reviewed
Dec 12, 2023
wsbrunson
reviewed
Dec 13, 2023
elizabethmv
force-pushed
the
shopper-insights
branch
from
394caaa to
d957a1b
Compare
elizabethmv
changed the title
elizabethmv
force-pushed
the
shopper-insights
branch
from
1e0d0d9 to
ee092c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Shopper Insights component which exposes a
getRecommendedPaymentMethods({})helper intended for combined use with the SPBs to present PayPal or Venmo upstream. It is also initially a protected export accessible on the PayPal domain until we open up the feature.Right now we are using existing kraken libraries to support the requests (Belter, ZalgoPromise) but we will be creating a separate PR to use the fetch API. We wanted to break this out so that we can get more dedicated feedback on that separately.