feat: add support for PPCP AXO Loader #2272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgdibble
commented
Nov 3, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## axo-on-ppcp #2272 +/- ##
==============================================
Coverage ? 51.18%
==============================================
Files ? 104
Lines ? 2032
Branches ? 601
==============================================
Hits ? 1040
Misses ? 889
Partials ? 103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cgdibble
commented
Nov 6, 2023
* Add Venmo overlay to checkout and Venmo zoid components * Add Venmo overlay content * Add interrogativeMessage to content * Remove types * Hardcode English for Venmo overlay * Use dot notation * Increase maxPercentIncrease
sunnypatel
reviewed
Nov 13, 2023
sunnypatel
reviewed
Nov 14, 2023
|
Closing as we needed the feature prefix for CI and went straight to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support loading AXO from PPCP
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!