-
Notifications
You must be signed in to change notification settings - Fork 208
Conversation
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 172 172
Branches 47 47
=====================================
Hits 172 172 Continue to review full report at Codecov.
|
Right now you can pass through glamorous('input', { forwardProps: 'onInvalid' }) But I think it'll make more sense to include this in the default component factory: glamorous.input |
Hi @tvler! Thanks for the PR. Is |
Hey! Yep, the event was added in v15 in the PR facebook/react#5187. It just was never added to the events documentation page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect. Thank you !
Thank you so much! |
No problem! Awesome library btw, iFixit's really diggin it 👍 |
Awesome! Could you add iFixit to the Users.md? |
What:
Adds
onInvalid
to list of react props to pass through.Why:
onInvalid
is a supported react event, but it isn't documented on the SyntheticEvent page (facebook/react#10554).How:
Added
onInvalid
to thereact-props.js
array.Checklist: