Skip to content
This repository has been archived by the owner on Sep 29, 2023. It is now read-only.

[QUESTION] Format converter decimal values #973

Closed
kslimani opened this issue Nov 6, 2017 · 2 comments
Closed

[QUESTION] Format converter decimal values #973

kslimani opened this issue Nov 6, 2017 · 2 comments
Labels
sdk-bug

Comments

@kslimani
Copy link

kslimani commented Nov 6, 2017

General information

  • SDK/Library version: master branch
  • Environment: Sandbox
  • PayPal-Debug-ID values: not required
  • Language, language version, and OS: PHP 7

Issue description

In the Currency Codes REST APIs documentation, it is stated that Hungarian forint (HUF) currency does not support decimals.

In the format converter helper class, it seems that only JPN and TWD currencies are checked.

Does this currency is missing in SDK or it is the documentation which is not up to date ?

Regards,
@xiaoleih41
Copy link
Contributor

We are looking into this.

jaypatel512 pushed a commit that referenced this issue Nov 6, 2017
Add HUF as non-decimal currency
16fb0c4 
- Fixes #973.
@jaypatel512 jaypatel512 mentioned this issue Nov 6, 2017
Merged
@randstraw
Copy link

Closing in favor of this pull request to address the issue #974. Thank you for bringing it to our attention.

jaypatel512 added a commit that referenced this issue Nov 6, 2017
@jaypatel512
Add HUF as non-decimal currency (#974)
26dadbf 
- Fixes #973.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
sdk-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xiaoleih41 @kslimani @randstraw