fix(ui): accept files with valid catchall mimetypes in bulkUpload #8868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhrarovsaid
changed the title
|
Just saw this gem of a PR and will be closing in favor of it for the following reasons:
|
|
Ah @akhrarovsaid my bad, I did not see this PR. I would’ve taken this and gone from here! thank you very very much for your Eagle eye |
|
@jmikrut No worries at all! It's my pleasure - just glad this got resolved and in excellent fashion. Your PR helped me identify better practices here for future PRs to come. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8867
Solution for this came from existing valid mimetype validator found here.