Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db-mongodb): v2-v3 migration versions docs of collections and globals without relationship fields #10755

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix(db-mongodb): v2-v3 migration versions docs of collections and globals without relationship fields #10755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 36 additions & 32 deletions packages/db-mongodb/src/predefinedMigrations/migrateRelationshipsV2_V3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,18 +111,20 @@ export async function migrateRelationshipsV2_V3({

const session = await getSession(db, req)

for (const collection of payload.config.collections.filter(hasRelationshipOrUploadField)) {
payload.logger.info(`Migrating collection "${collection.slug}"`)
for (const collection of payload.config.collections) {
if (hasRelationshipOrUploadField(collection)) {
payload.logger.info(`Migrating collection "${collection.slug}"`)

await migrateModelWithBatching({
batchSize,
config,
fields: collection.fields,
Model: db.collections[collection.slug],
session,
})
await migrateModelWithBatching({
batchSize,
config,
fields: collection.fields,
Model: db.collections[collection.slug],
session,
})

payload.logger.info(`Migrated collection "${collection.slug}"`)
payload.logger.info(`Migrated collection "${collection.slug}"`)
}

if (collection.versions) {
payload.logger.info(`Migrating collection versions "${collection.slug}"`)
Expand All @@ -141,33 +143,35 @@ export async function migrateRelationshipsV2_V3({

const { globals: GlobalsModel } = db

for (const global of payload.config.globals.filter(hasRelationshipOrUploadField)) {
payload.logger.info(`Migrating global "${global.slug}"`)

const doc = await GlobalsModel.findOne<Record<string, unknown>>(
{
globalType: {
$eq: global.slug,
},
},
{},
{ lean: true, session },
)

// in case if the global doesn't exist in the database yet (not saved)
if (doc) {
sanitizeRelationshipIDs({ config, data: doc, fields: global.fields })
for (const global of payload.config.globals) {
if (hasRelationshipOrUploadField(global)) {
payload.logger.info(`Migrating global "${global.slug}"`)

await GlobalsModel.collection.updateOne(
const doc = await GlobalsModel.findOne<Record<string, unknown>>(
{
globalType: global.slug,
globalType: {
$eq: global.slug,
},
},
{ $set: doc },
{ session },
{},
{ lean: true, session },
)
}

payload.logger.info(`Migrated global "${global.slug}"`)
// in case if the global doesn't exist in the database yet (not saved)
if (doc) {
sanitizeRelationshipIDs({ config, data: doc, fields: global.fields })

await GlobalsModel.collection.updateOne(
{
globalType: global.slug,
},
{ $set: doc },
{ session },
)
}

payload.logger.info(`Migrated global "${global.slug}"`)
}

if (global.versions) {
payload.logger.info(`Migrating global versions "${global.slug}"`)
Expand Down