Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CTRL | CMD) + S still works with with autosave set #9770

Closed
PP-Tom opened this issue Dec 5, 2024 · 3 comments · Fixed by #10993
Closed

(CTRL | CMD) + S still works with with autosave set #9770

PP-Tom opened this issue Dec 5, 2024 · 3 comments · Fixed by #10993
Assignees

Comments

@PP-Tom
Copy link

PP-Tom commented Dec 5, 2024

Describe the Bug

When you have autosave set, it's still possible to create a draft with CTRL + S or CMD + S, this creates unexpected behaviour such as deleting search indexes.

Link to the code that reproduces this issue

pnpx create-payload-app@latest -t blank

Reproduction Steps

  1. Enable autosave on a collection.
  2. Press CTRL + S or CMS + S

Which area(s) are affected? (Select all that apply)

plugin: search, Not sure

Environment Info

Payload: 3.4.0
NodeJS: 22
NextJS: 15.0.3
@PP-Tom PP-Tom added status: needs-triage Possible bug which hasn't been reproduced yet validate-reproduction labels Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Please add a reproduction in order for us to be able to investigate.

Depending on the quality of reproduction steps, this issue may be closed if no reproduction is provided.

Why was this issue marked with the invalid-reproduction label?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We prefer a link to a public GitHub repository created with create-payload-app@beta -t blank or a forked/branched version of this repository with tests added (more info in the reproduction-guide).

To make sure the issue is resolved as quickly as possible, please make sure that the reproduction is as minimal as possible. This means that you should remove unnecessary code, files, and dependencies that do not contribute to the issue. Ensure your reproduction does not depend on secrets, 3rd party registries, private dependencies, or any other data that cannot be made public. Avoid a reproduction including a whole monorepo (unless relevant to the issue). The easier it is to reproduce the issue, the quicker we can help.

Please test your reproduction against the latest version of Payload to make sure your issue has not already been fixed.

I added a link, why was it still marked?

Ensure the link is pointing to a codebase that is accessible (e.g. not a private repository). "example.com", "n/a", "will add later", etc. are not acceptable links -- we need to see a public codebase. See the above section for accepted links.

Useful Resources

@github-actions github-actions bot added the stale label Jan 5, 2025
@paulpopus paulpopus self-assigned this Feb 2, 2025
@github-actions github-actions bot removed the status: needs-triage Possible bug which hasn't been reproduced yet label Feb 2, 2025
@paulpopus
Copy link
Contributor

I don't think this issue is in particular with the hotkey to save while autosave is enabled. The search plugin issue can happen without autosave as well so I'll be fixing that by adding an additional check for a published version and only then removing the search doc if no published versions exist.

If you see any other issues regarding these flows let us know and we can handle that directly.

paulpopus added a commit that referenced this issue Feb 5, 2025
…on (#10993)

Fixes #9770

If you had a published document but then created a new draft it would
delete the search doc, this PR adds an additional find to check if an
existing published doc exists before deleting the search doc.

Also adds a few jsdocs to plugin config
@github-actions github-actions bot removed the stale label Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

🚀 This is included in version v3.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants