Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline block drawer doesn’t open when inserting a inline block #9532

Closed
ChannKan opened this issue Nov 26, 2024 · 5 comments · Fixed by #9613
Closed

Inline block drawer doesn’t open when inserting a inline block #9532

ChannKan opened this issue Nov 26, 2024 · 5 comments · Fixed by #9613

Comments

@ChannKan
Copy link

Describe the Bug

When inserting a inline-block into a rich-text field it is added immediately without opening the drawer first

Link to the code that reproduces this issue

https://github.com/shefing/payload_Inline_block_with_relationship/tree/Check_inline_block

Reproduction Steps

Steps to reproduce:

  1. Clone the link to reproduction ripo and launch Payload
  2. Create a new Post instance
  3. Add a inline-block to the rich-text field

Expected:
Inline-block drawer is opened

Actual:
Inline-block drawer doesn’t open and a empty inline-block is added in the rich-text field

Which area(s) are affected? (Select all that apply)

plugin: richtext-lexical

Environment Info

Payload: 3.1.0
Node.js: 22.11.0
Next.js: 15.0.3
@ChannKan ChannKan added status: needs-triage Possible bug which hasn't been reproduced yet validate-reproduction labels Nov 26, 2024
@ChannKan

This comment has been minimized.

Sign in to view
@Spreizu

This comment has been minimized.

Sign in to view
@SimYunSup SimYunSup mentioned this issue Nov 29, 2024
Merged
AlessioGr pushed a commit that referenced this issue Nov 29, 2024
@SimYunSup
fix(richtext-lexical): add form id to drawSlug (#9613)
9892303 
Fixes #9532 

The error occurs because the drawerSlug declaration in
`blocks/client/component` contains `formData.id`, while
`blocks/client/componentInline` does not. So I add `formData.id`.

### Before



https://github.com/user-attachments/assets/14247634-ab60-437f-8986-c76cafec5c09


### After


https://github.com/user-attachments/assets/b26bc1ca-b071-4bf5-a9f0-fda4e9282538
@github-actions github-actions bot removed the status: needs-triage Possible bug which hasn't been reproduced yet label Nov 29, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2024
@github-actions github-actions bot unlocked this conversation Dec 3, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
@AlessioGr AlessioGr reopened this Dec 5, 2024
@github-actions github-actions bot added the status: needs-triage Possible bug which hasn't been reproduced yet label Dec 5, 2024
@AlessioGr
Copy link
Member

#9816

@github-actions github-actions bot removed the status: needs-triage Possible bug which hasn't been reproduced yet label Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(richtext-lexical): add form id to drawSlug SimYunSup/payload
3 participants
@Spreizu @AlessioGr @ChannKan