Use FeeRate::BROADCAST_MIN for minfeerate defaults #493
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanGould
force-pushed
the
min-feerate-broadcast
branch
2 times, most recently
from
540bcef to
11e477c
Compare
Relay policy's BROADCAST_MIN is far more usual than FeeRate::MIN (ZERO) when it comes to thinking of minnimum feerates to paramaterize. Use the default in payjoin-cli since it is a reference implementation. This is only a default. If some implementation wants to use a lower fee rate they still may. Close payjoin#489
Pull Request Test Coverage Report for Build 12848937429Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relay policy's BROADCAST_MIN is far more usual than FeeRate::MIN (ZERO) when it comes to thinking of minnimum feerates to paramaterize.
This is only a default. If some implementation wants to use a lower fee rate they still may.
Close #489