PAYARA-4000 A REST management DELETE command returns 415 code instead of 404 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGill98
suggested changes
Aug 15, 2019
added 2 commits
August 16, 2019 09:57
PAYARA-4000 A REST management DELETE command returns 415 code instead of 404
AlanRoth
changed the title
MattGill98
approved these changes
Aug 16, 2019
MattGill98
suggested changes
Aug 16, 2019
There was a problem hiding this comment.
My fault, but I've just checked and the tests sem to fail:
WARNING: Entity must be null for http method DELETE.
[ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.075 s <<< FAILURE! - in org.glassfish.jersey.client.JerseyInvocationTest
[ERROR] overrideHttpMethodBasedComplianceCheckTest(org.glassfish.jersey.client.JerseyInvocationTest) Time elapsed: 0.011 s <<< FAILURE!
java.lang.AssertionError: ProcessingException expected.
at org.glassfish.jersey.client.JerseyInvocationTest.overrideHttpMethodBasedComplianceCheckTest(JerseyInvocationTest.java:117)
This seems related to the fix. Is this a test that needs fixing or a genuine failure?
MattGill98
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.