Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-6472 #6544

Merged
merged 2 commits into from
Jul 4, 2024
Merged

FISH-6472 #6544

merged 2 commits into from
Jul 4, 2024

Conversation

myresd
Copy link
Contributor

@myresd myresd commented Jan 29, 2024

Description

Fixes the issue where an incorrect string is returned for JDBC resource transaction isolation level. Also fixes a typo in the property description.

Important Info

Blockers

Testing

New tests

Testing Performed

Testing Environment

Documentation

Notes for Reviewers

@Pandrex247 Pandrex247 added the PR: Awaiting CLA Contributor does not have a CLA or has submitted an unconfirmed CLA. label Apr 25, 2024
@Pandrex247
Copy link
Member

I don't see a CLA for your GitHub user on record, would you be able to submit one please?
https://github.com/payara/Payara/blob/master/.github/CONTRIBUTING.md#legal-bits

The change otherwise LGTM 👍

@kalinchan
Copy link
Member

Hi @myresd,

Thanks for the contribution, however, a CLA is required and if we do not receive one by 1st July 2024 we will close this PR.

@myresd
Copy link
Contributor Author

myresd commented Jun 26, 2024

Hi @kalinchan ,

Thanks for the reminder, I submitted a CLA.

@smillidge smillidge added PR: CLA CLA submitted on PR by the contributor and removed PR: Awaiting CLA Contributor does not have a CLA or has submitted an unconfirmed CLA. labels Jul 1, 2024
@kalinchan kalinchan merged commit 9deb480 into payara:master Jul 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: CLA CLA submitted on PR by the contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants