-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FISH-7959: Fixes MultiRelease JAR lookup for specific version classes #6460
FISH-7959: Fixes MultiRelease JAR lookup for specific version classes #6460
Conversation
6bd1546
to
02d73a7
Compare
Jenkins test please |
Jenkins test please |
…tirelease-jar-lookup
Jenkins test please |
1 similar comment
Jenkins test please |
@ctabin I simplify a little the way to use the JarEntry, now it is more simple to create the JarFile using following constructor: JarFile(File, boolean, int, Runtime.Version), here more documentation: after testing with your reproducer the test is passing with success: INFO: Shutdown procedure finished ` thank you for your contribution |
@breakponchito Thank you very much ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- maven-jar-plugin:3.3.0:jar (default-jar) @ launcher ---
[INFO] Building jar: C:\code\reproducers\gf-test-lucene\launcher\target\launcher-1.0.0-SNAPSHOT.jar
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for GF Project (Main) 1.0.0-SNAPSHOT:
[INFO]
[INFO] GF Project (Main) .................................. SUCCESS [ 0.277 s]
[INFO] GF Project (API) ................................... SUCCESS [ 1.343 s]
[INFO] GF Project (EJB) ................................... SUCCESS [ 1.390 s]
[INFO] GF Project (WAR) ................................... SUCCESS [ 0.665 s]
[INFO] GF Project (EAR) ................................... SUCCESS [ 1.535 s]
[INFO] GF Project (Launcher) .............................. SUCCESS [ 16.658 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22.027 s
[INFO] Finished at: 2023-11-01T14:03:22-03:00
[INFO] ------------------------------------------------------------------------
Description
This PR fixes lookup of classes in MultiRelease JARs for version-specific classes. Fixes #6452.
Testing Performed
Tested on my reproducer
Testing Environment
OpenJDK 21, Linux Debian
Azul JDK 21, Ubuntu 20.04