Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-7716 openjava.base/java.io on jdk 17 #6371

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

aubi
Copy link
Contributor

@aubi aubi commented Aug 19, 2023

Description

Cargotracker didn't run on JDK 17. The required --add-opens is used from JDK 21. This PR lowers the required JDK to 17.

Testing

Testing Performed

  • Compile Payara
  • checkout Cargotracker: git clone [email protected]:eclipse-ee4j/cargotracker.git
  • change version of Payara to use in pom.xml: <payara.version>6.2023.9-SNAPSHOT</payara.version>
  • run cargotracker in JDK 17: JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64 mvn clean package -DskipTests cargo:run

Testing Environment

Linux, OpenJDK 11 (to compile Payara), OpenJDK 17 to run

@aubi
Copy link
Contributor Author

aubi commented Aug 19, 2023

Jenkins test please

@Pandrex247 Pandrex247 changed the title openjava.base/java.io on jdk 17 FISH-7716 openjava.base/java.io on jdk 17 Aug 21, 2023
@breakponchito breakponchito self-requested a review August 21, 2023 14:38
Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants